-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CVR): enable REBUILD_ESTIMATES feature gate #1670
Merged
vishnuitta
merged 3 commits into
openebs-archive:master
from
mittachaitu:remove_feature_gates
Apr 22, 2020
Merged
chore(CVR): enable REBUILD_ESTIMATES feature gate #1670
vishnuitta
merged 3 commits into
openebs-archive:master
from
mittachaitu:remove_feature_gates
Apr 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
vishnuitta
reviewed
Apr 15, 2020
vishnuitta
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good.. one minor comment on log level
mynktl
approved these changes
Apr 16, 2020
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mynktl
approved these changes
Apr 16, 2020
mittachaitu
added
pr/ready-to-merge
PR has enough approvals and ready to merge
pr/release-note
PR should be included in release notes
labels
Apr 16, 2020
This was referenced Apr 16, 2020
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mynktl
approved these changes
Apr 22, 2020
vishnuitta
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr/ready-to-merge
PR has enough approvals and ready to merge
pr/release-note
PR should be included in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io
What this PR does / why we need it:
LogicalReferenced: Size in bytes of the volume when the snapshot was taken.
Example CVR YAML:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release Note:
REBUILD_ESTIMATES
feature gate by default so that CVR status will have a list of snapshots and pending snapshots. The list under snapshots represents snapshots created for that volume and pendingSnapshots represents snapshots that are yet to rebuild from the peer replicas.Checklist:
documentation
tagbreaking-changes
tagrequires-upgrade
tag