refact(build): make the docker images configurable #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will help customizing docker images via environment variables: - The following ENV help specify custom docker build args - DBUILD_SITE_URL ( default: https://openebs.io ) - DBUILD_REPO_URL ( default: https://github.com/openebs/maya ) - The following ENV allows Travis to specify custom image org - IMAGE_ORG (default: openebs ) - The following ENV will allow specifying an extra tag suffix - TAG_SUFFIX ( default: none ) Notes: - Replace HUB_USER with IMAGE_ORG - Tag the downstream based on the repo on which builds are triggered Signed-off-by: kmova <kiran.mova@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
This commit enables users to build images from forked repos.
What this PR does?:
This commit will help to customize docker images via environment variables:
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Travis will verify the building of images.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Signed-off-by: kmova kiran.mova@mayadata.io
Checklist:
<type>(<scope>): <subject>