Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cstor-restore): fixing restore api to return failure if cstorrestore is in invalid state #1682

Merged
merged 2 commits into from
May 5, 2020

Conversation

mynktl
Copy link
Contributor

@mynktl mynktl commented May 5, 2020

Why is this PR required? What issue does it fix?:
This PR is required to fix the issue #1677.

What this PR does?:
This PR updates the REST api for cstore restore to report failure if cstorrestore resource is in invalid state.
There is one additional change in restore controller in cstor-pool-mgmt to ignore the update if cstorrestore CR is having state Done or Failed

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::

  • Restart the cstor-pool pod when restore is in-progress state
    - outcome is restore failed
  • Restart the cstor-pool pod before it process the cstorrestore CR
    - outcome is restore failed
  • Restart the cstor-pool pod once it update the cstorrestore CR to init state
    - outcome is restore failed
  • Restart the cstor-pool pod once the restore completes
    - outcome is cstorrestore status remains same

Checklist:

Signed-off-by: mayank mayank.patel@mayadata.io

Signed-off-by: mayank <mayank.patel@mayadata.io>
Signed-off-by: mayank <mayank.patel@mayadata.io>
@kmova kmova merged commit 220895a into openebs-archive:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore completed successfully but one of the replica was not having the snapshot restored
2 participants