fix(cstor-restore): fixing restore api to return failure if cstorrestore is in invalid state #1682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
This PR is required to fix the issue #1677.
What this PR does?:
This PR updates the REST api for cstore restore to report failure if cstorrestore resource is in invalid state.
There is one additional change in restore controller in cstor-pool-mgmt to ignore the update if cstorrestore CR is having state
Done
orFailed
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
- outcome is restore failed
- outcome is restore failed
- outcome is restore failed
- outcome is cstorrestore status remains same
Checklist:
Signed-off-by: mayank mayank.patel@mayadata.io