feat(install): enable/disable crd installation #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When helm install for openebs was introduced, there was no way for helm to install CRDs. So api-server included the code to install the CRDs as part of initialization. With Helm 3, the CRDs can be installed via helm. There have been some requests for moving the CRD installations outside of the code for cases where Kubernetes installers like Lokomotive and others, would like granular control on how the required objects are installed. This commit adds an ENV variable that allows users to enable/disable the CRD install code. Signed-off-by: kmova <kiran.mova@mayadata.io>
|
@kmova Is the same set of changes required in NDM, for the installation of |
|
@akhilerm - probably makes sense to add for NDM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kmova kiran.mova@mayadata.io
Why is this PR required? What issue does it fix?:
When helm install for openebs was introduced,
there was no way for helm to install CRDs. So
api-server included the code to install the CRDs
as part of initialization.
With Helm 3, the CRDs can be installed via
helm. There have been some requests for moving
the CRD installations outside of the code for
cases where Kubernetes installers like Lokomotive
and others, would like granular control on
how the required objects are installed.
What this PR does?:
This commit adds an ENV variable that allows
users to enable/disable the CRD install code.
Does this PR require any upgrade changes?:
NA
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>