skip validations checks and handle snapshot deletion once migrated to CSI #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some cases like volume migration where we need to delete the old pvc and create new based on CSI, in such cases we need to ignore/skip the validations. Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
prateekpandey14
force-pushed
the
handle-volume-migration
branch
2 times, most recently
from
ffd134a to
fcc0d1f
Compare
prateekpandey14
changed the title
prateekpandey14
force-pushed
the
handle-volume-migration
branch
from
fcc0d1f to
02dc0c1
Compare
prateekpandey14
force-pushed
the
handle-volume-migration
branch
from
02dc0c1 to
2f82132
Compare
mittachaitu
reviewed
Jun 8, 2020
prateekpandey14
force-pushed
the
handle-volume-migration
branch
from
2f82132 to
379d5de
Compare
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
prateekpandey14
force-pushed
the
handle-volume-migration
branch
from
379d5de to
a8c40f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
PR required to handle PVC validation checks before starting the volume migration operations,
for example, ignore the PVC deletion if snapshots are exists.
What this PR does?:
Add skip validations checks in webhook validations via annotations:
There are some cases like volume migration where we need to delete
the old pvc and create new pvc based on CSI, in such cases we need
to ignore/skip the validations related to snapshots .
Ignore old snapshots delete request once migrated to CSI based volumes. Once we migrate the volumes to CSI, we have to migrate the snapshot as well, once snapshots are migrated, backend snapshot will be bind to new CSI snapshot type, and it requires clean up of the older snapshot related resources as they are no longer requried. This change will allow user to delete the snapshot of old types (not from the pools which is bind to the new csi snapshot types)
Does this PR require any upgrade changes?:
NO
If the changes in this PR are manually verified, list down the scenarios covered::
Checklist:
<type>(<scope>): <subject>