refact(webhook): make webhook config failure policy configurable #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit enable the webhook validatingwebhookconfiguration failure policy configurable using a env called ADMISSION_WEBHOOK_FAILURE_POLICY. There are 2 types of failure policy which can be configurable are `Fail` and `Ignore`. `Fail` will be the default policy Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
prateekpandey14
force-pushed
the
failure-policy
branch
from
c998108 to
a3a4050
Compare
kmova
approved these changes
Jul 1, 2020
|
@prateekpandey14 -- does this need change in the upgrade code, that recreates the validation hooks? |
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
kmova
reviewed
Jul 1, 2020
prateekpandey14
added a commit
to prateekpandey14/maya
that referenced
this pull request
Jul 2, 2020
…nebs-archive#1726) commit enable the webhook validatingwebhookconfiguration failure policy configurable using a env called ADMISSION_WEBHOOK_FAILURE_POLICY. There are 2 types of failure policy which can be configurable are `Fail` and `Ignore`. `Fail` will be the default policy Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Jul 2, 2020
commit enable the webhook validatingwebhookconfiguration failure policy configurable using a env called ADMISSION_WEBHOOK_FAILURE_POLICY. There are 2 types of failure policy which can be configurable are `Fail` and `Ignore`. `Fail` will be the default policy Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
make webhook validatingwebhookconfiguration configurable
What this PR does?:
commit enable the webhook validatingwebhookconfiguration
failure policy configurable using a env called
ADMISSION_WEBHOOK_FAILURE_POLICY.
There are 2 types of failure policy which can be configurable
are
FailandIgnore.Failwill be the default policyDoes this PR require any upgrade changes?:
NO
If the changes in this PR are manually verified, list down the scenarios covered::
ignorefailure policy and verified that it got configured properlyChecklist:
<type>(<scope>): <subject>