fix(upgrade): allow upgrades for volumes without monitor #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
OpenEBS provides an option to disable volume monitor which results in one less container for the m-exporter image. This PR allows upgrade to work irrespective of whether the monitor is enabled or not.
If the changes in this PR are manually verified, list down the scenarios covered::
Tested both Volume Monitor enabled and disabled for both jiva and cstor.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>