fix(webhook): update webhook config sideEffects to None #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support dry run command, validatingwebhookconfiguration SideEffects needs to be set as None. Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
kmova
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prateekpandey14 prateek.pandey@mayadata.io
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
To support dry run command, validatingwebhookconfiguration
SideEffectsneeds to be set asNone.What this PR does?:
Does this PR require any upgrade changes?:
NO
If the changes in this PR are manually verified, list down the scenarios covered::
Manual testing is done with upgrade to latest ci build.
fixes: #1771
Checklist:
<type>(<scope>): <subject>