Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): remove stale cstor code #1787

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Mar 4, 2021

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:
As part of deprecating this repo and upgrading the k8s dependencies for the last time, we are going to remove unused and stale code from the repo. This PR removes the stale cstor code which has been moved to openebs/cstor-operators repo.

The CRD code of cstor-pool-mgmt code related to SPC management, has moved to openebs/api.

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Contributor

@kmova kmova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just to confirm, the cstor-pool-mgmt related files being removed are deprecated due to the v1 migration. Is this right?

@kmova kmova merged commit c9c6429 into openebs-archive:master Mar 5, 2021
@prateekpandey14
Copy link
Contributor

Just to confirm, the cstor-pool-mgmt related files being removed are deprecated due to the v1 migration. Is this right?

Yes @kmova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants