Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed case for listing cStor volumes #1

Closed
vaniisgh opened this issue Jul 14, 2020 · 2 comments
Closed

Missed case for listing cStor volumes #1

vaniisgh opened this issue Jul 14, 2020 · 2 comments
Assignees
Labels
cStor Deals with cStor engine volume command

Comments

@vaniisgh
Copy link
Collaborator

When a PVC is provisioned and the CStorVolume might not be created the current logic is not sufficient to list the instances.

@kmova
Copy link
Member

kmova commented May 14, 2021

This can be expanded into a few more test cases like:

  • Checking what is the minimum OpenEBS version required for openebsctl to work. And in case user tries with older openebs version, does it gracefully error out?
  • Test the commands by breaking the components - for example if listing cstor volume:
    • create a PV (with reclaim policy as retain), delete the PVC
    • create a PV - delete manually some of the sub CRs and check if openebsctl can gracefully validate and display missing information

@Abhinandan-Purkait
Copy link
Member

We have tried the above mentioned cases and these are the observations:

  • If CstorVolume is not created, the get command will not the list the volume.
  • If PVC is deleted and the volume has a reclaim policy of Retain, then the flow works as expected, the CstorVolume is listed and the describe also works without any error.
  • If subCR like CVC is deleted then theCstorVolume and the CVR also gets deleted and thus it is will not list the CstorVolume. Although if we do a kubectl get pv we will be able to see the PV and if we pass the PV name in the kubectl openebs volume describe command it will show a error i.e. failed to execute volume info command, getting cStor volumes: error while while getting volume <volume name>: cstorvolumes.cstor.openebs.io "<volume name>" not found.
  • If subCR like CVR is deleted then the flow works as expected i.e the CstorVolume will be listed and on describe in the replica section it shows None of the replicas are running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cStor Deals with cStor engine volume command
Projects
None yet
Development

No branches or pull requests

3 participants