Skip to content

Commit

Permalink
fix(helm): Possibility to override zfs encryption keys directory
Browse files Browse the repository at this point in the history
Helm charts was hardcoding zfs encryption keys directory and on some
distributions /home is read-only. This commit will make it possible to
set it as a helm value.

Fixes #477

Signed-off-by: Wagner Sartori Junior <wsartori@wsartori.com>
  • Loading branch information
trunet committed Nov 15, 2023
1 parent 21fafa2 commit 15ef65d
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelogs/unreleased/487-trunet.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix(helm): Possibility to override zfs encryption keys directory
2 changes: 1 addition & 1 deletion deploy/helm/charts/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: zfs-localpv
description: Helm chart for CSI Driver for dynamic provisioning of ZFS Persistent Local Volumes. For instructions on how to use this helm chart, see - https://openebs.github.io/zfs-localpv/
version: 2.3.1
version: 2.3.2
appVersion: 2.3.0
icon: https://raw.githubusercontent.com/cncf/artwork/master/projects/openebs/icon/color/openebs-icon-color.png
home: https://openebs.io/
Expand Down
1 change: 1 addition & 0 deletions deploy/helm/charts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ The following table lists the configurable parameters of the OpenEBS ZFS Localpv
| `zfsNode.driverRegistrar.image.tag`| Image tag for csi-node-driver-registrar| `v2.8.0`|
| `zfsNode.updateStrategy.type`| Update strategy for zfsnode daemonset | `RollingUpdate` |
| `zfsNode.kubeletDir`| Kubelet mount point for zfsnode daemonset| `"/var/lib/kubelet/"` |
| `zfsNode.encrKeysDir` | Zfs encryption key directory| `"/home/keys"` |
| `zfsNode.annotations` | Annotations for zfsnode daemonset metadata| `""`|
| `zfsNode.podAnnotations`| Annotations for zfsnode daemonset's pods metadata | `""`|
| `zfsNode.resources`| Resource and request and limit for zfsnode daemonset containers | `""`|
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/charts/templates/zfs-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ spec:
type: Directory
- name: encr-keys
hostPath:
path: /home/keys
path: {{ .Values.zfsNode.encrKeysDir }}
type: DirectoryOrCreate
- name: chroot-zfs
configMap:
Expand Down
1 change: 1 addition & 0 deletions deploy/helm/charts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ zfsNode:
# This can be configured to run on various different k8s distributions like
# microk8s where kubelet dir is different
kubeletDir: "/var/lib/kubelet/"
encrKeysDir: "/home/keys"
# limits:
# cpu: 10m
# memory: 32Mi
Expand Down

0 comments on commit 15ef65d

Please sign in to comment.