Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usage): include pvc name in volume events #150

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

pawanpraka1
Copy link
Contributor

Signed-off-by: Pawan pawan@mayadata.io

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on

@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label Jun 8, 2020
@pawanpraka1 pawanpraka1 added this to the v0.8.0 milestone Jun 8, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova June 8, 2020 06:45
Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #150 into master will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   22.90%   22.71%   -0.19%     
==========================================
  Files          14       14              
  Lines         489      493       +4     
==========================================
  Hits          112      112              
- Misses        376      380       +4     
  Partials        1        1              
Impacted Files Coverage Δ
pkg/usage/googleanalytics.go 0.00% <0.00%> (ø)
pkg/usage/usage.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e558bb5...6db2f6f. Read the comment docs.

@kmova kmova merged commit b08a1e2 into openebs:master Jun 8, 2020
@pawanpraka1 pawanpraka1 deleted the google branch June 9, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants