-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(doc): Update docs for Gomodule support #160
Conversation
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 14 14
Lines 490 490
=======================================
Hits 111 111
Misses 378 378
Partials 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@vaniisgh can you add change log in this PR? |
not sure why my re-base did this .. should I open a fresh PR? |
you can fix the changes, and force push(git push -f) here in the same PR only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
@vaniisgh can you DCO sign off all the commits? Few commits are not having DCO sign, not able to merge it. |
yes sorry about all this, my focus is not good at the moment. |
- updated docs to reflect use of gomodules Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Files Changed
Why is this PR required? What issue does it fix?:
Updating docs as well as a very small fix in the build scripts to support go modules.
What this PR does?:
Adds the required updates.
Any additional information for your reviewer? :
Just a small question about this file zfs-localpv/buildscripts/zfs-driver/Dockerfile
this line
RUN apt-get -y install rsyslog libssl-dev xfsprogs ca-certificates
breaks code on my local machine, should I expect this? and how can I fix this ? :)Checklist:
<type>(<scope>): <subject>