Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zfspv) add go lint target #167

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Conversation

vaniisgh
Copy link
Contributor

@vaniisgh vaniisgh commented Jun 29, 2020

Why is this PR required? What issue does it fix?:
adds a target for lint as needed by #165

Questions
should the golint output be formatted before printing somehow ... ?

also i need to fix the spelling for recommendations, will do with the change-log or any additional changes :)

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   22.65%   22.65%           
=======================================
  Files          14       14           
  Lines         490      490           
=======================================
  Hits          111      111           
  Misses        378      378           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d1664...e4a00e1. Read the comment docs.

@pawanpraka1
Copy link
Contributor

pawanpraka1 commented Jun 30, 2020

@vaniisgh this looks good. are there any golint error you are getting? if yes, would you like to fix them in the coming PR? We will add make golint command in the travis yaml and will make it fail if there are any linting error. But before doing that, we have to fix all the linting errors we have now.

@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label Jun 30, 2020
@pawanpraka1 pawanpraka1 added this to the v0.9 milestone Jun 30, 2020
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@vaniisgh
Copy link
Contributor Author

so, I'll fix the other recommendations in this PR and the go-lint errors in a new one? :) right?

@pawanpraka1
Copy link
Contributor

fix the recommendation given in this PR only. And for fixing the go-lint and adding it to the travis can be taken in a new PR.

@pawanpraka1
Copy link
Contributor

Also, add the changelog file.

Signed-off-by: vaniisgh <vanisingh@live.co.uk>
@vaniisgh
Copy link
Contributor Author

I'll fix the linting errors & add to Travis in a new PR, should I open an issue for the same ... I'll take care of it in a day or two though :)

Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@pawanpraka1 pawanpraka1 merged commit ac9d6d5 into openebs:master Jun 30, 2020
@pawanpraka1
Copy link
Contributor

@vaniisgh yes, you can open an issue for that.

@pawanpraka1 pawanpraka1 linked an issue Jul 2, 2020 that may be closed by this pull request
@vaniisgh vaniisgh deleted the addLintTarget branch July 2, 2020 10:18
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add golint end point in the Makefile
3 participants