Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(btrfs): adding support to have btrfs filesystem for ZFS-LocalPV #170

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Jul 1, 2020

fixes: #169

Now, applications can use the btrfs file system by mentioning "btrfs"
as fstype in the storageclass :-

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: openebs-zfspv
parameters:
  fstype: "btrfs"
  poolname: "zfspv-pool"
provisioner: zfs.csi.openebs.io

Signed-off-by: Pawan pawan@mayadata.io

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label Jul 1, 2020
@pawanpraka1 pawanpraka1 added this to the v0.9 milestone Jul 1, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova July 1, 2020 17:13
Now, applications can use the btrfs file system by mentioning "btrfs"
as fstype in the storageclass :-

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: openebs-zfspv
parameters:
  fstype: "btrfs"
  poolname: "zfspv-pool"
provisioner: zfs.csi.openebs.io

Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   22.65%   22.65%           
=======================================
  Files          14       14           
  Lines         490      490           
=======================================
  Hits          111      111           
  Misses        378      378           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9d6d5...09d8c77. Read the comment docs.

@kmova kmova merged commit 051f26f into openebs:master Jul 1, 2020
@pawanpraka1 pawanpraka1 deleted the btrfs branch July 1, 2020 19:13
@mikroskeem
Copy link

As mentioned in Slack, then btrfs needs rewriting the UUID similarly to XFS. Thus this PR does not fully implement the btrfs support yet.

image

pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
We changed the ubuntu docker image to 20.04 in openebs#170,
which has issues with formatting the zvol as xfs file system. The filesystem
formatted with xfs is not able to mount with error : "missing codepage or helper program, or other error".

Reverting back to ubuntu 19.10 to fix this issue.

Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
We changed the ubuntu docker image to 20.04 in openebs#170,
which has issues with formatting the zvol as xfs file system. The filesystem
formatted with xfs is not able to mount with error : "missing codepage or helper program, or other error".

Reverting back to ubuntu 19.10 to fix this issue.

Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
We changed the ubuntu docker image to 20.04 in openebs#170,
which has issues with formatting the zvol as xfs file system. The filesystem
formatted with xfs is not able to mount with error : "missing codepage or helper program, or other error".

Reverting back to ubuntu 19.10 to fix this issue.

Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1 added a commit that referenced this pull request Jul 9, 2020
We changed the ubuntu docker image to 20.04 in #170,
which has issues with formatting the zvol as xfs file system. The filesystem
formatted with xfs is not able to mount with error : "missing codepage or helper program, or other error".

Reverting back to ubuntu 19.10 to fix this issue.

Signed-off-by: Pawan <pawan@mayadata.io>
kmova pushed a commit that referenced this pull request Jul 9, 2020
We changed the ubuntu docker image to 20.04 in #170,
which has issues with formatting the zvol as xfs file system. The filesystem
formatted with xfs is not able to mount with error : "missing codepage or helper program, or other error".

Reverting back to ubuntu 19.10 to fix this issue.

Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BTRFS support in fsType
4 participants