Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zfspv): mounting the volume if it is ready #184

Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix(zfspv): mounting the volume if it is ready #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelogs/unreleased/184-pawanpraka1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
mounting the volume if it is ready
4 changes: 2 additions & 2 deletions pkg/zfs/mount.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ func verifyMountRequest(vol *apis.ZFSVolume, mountpath string) error {
vol.Spec.OwnerNodeID != NodeID {
return status.Error(codes.Internal, "verifyMount: volume is owned by different node")
}
if vol.Finalizers == nil {
return status.Error(codes.Internal, "verifyMount: volume is not ready, driver has not yet set the finalizer")
if vol.Status.State != ZFSStatusReady {
return status.Error(codes.Internal, "verifyMount: volume is not ready to be mounted")
}

devicePath, err := GetVolumeDevPath(vol)
Expand Down
6 changes: 0 additions & 6 deletions pkg/zfs/zfs_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,12 +370,6 @@ func CreateClone(vol *apis.ZFSVolume) error {
if vol.Spec.FsType == "btrfs" {
return btrfsGenerateUUID(volume)
}
if vol.Spec.FsType == "btrfs" {
return btrfsGenerateUUID(volume)
}
if vol.Spec.FsType == "btrfs" {
return btrfsGenerateUUID(volume)
}
return nil
}

Expand Down