Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(doc): adding volume capacity roundoff details in readme #188

Merged
merged 1 commit into from
Aug 10, 2020
Merged

chore(doc): adding volume capacity roundoff details in readme #188

merged 1 commit into from
Aug 10, 2020

Conversation

pawanpraka1
Copy link
Contributor

Signed-off-by: Pawan pawan@mayadata.io

@pawanpraka1 pawanpraka1 added the documentation Improvements or additions to documentation label Jul 30, 2020
@pawanpraka1 pawanpraka1 added this to the v0.10 milestone Jul 30, 2020
@pawanpraka1 pawanpraka1 requested review from kmova and w3aman July 30, 2020 12:59
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #188 into master will decrease coverage by 12.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #188       +/-   ##
==========================================
- Coverage   22.88%   9.88%   -13.00%     
==========================================
  Files          14      20        +6     
  Lines         485    1163      +678     
==========================================
+ Hits          111     115        +4     
- Misses        373    1047      +674     
  Partials        1       1
Impacted Files Coverage Δ
pkg/driver/grpc.go 0.00% <0.00%> (ø)
pkg/driver/driver.go 0.00% <0.00%> (ø)
pkg/driver/identity.go 0.00% <0.00%> (ø)
pkg/driver/scheduler.go 0.00% <0.00%> (ø)
pkg/driver/agent.go 0.00% <0.00%> (ø)
pkg/driver/controller.go 1.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4a0de...d4be900. Read the comment docs.

w3aman
w3aman reviewed Jul 30, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
w3aman
w3aman reviewed Jul 30, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
w3aman
w3aman approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@w3aman w3aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

kmova
kmova reviewed Jul 31, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pawanpraka1 pawanpraka1 mentioned this pull request Aug 6, 2020
Merged
7 tasks
kmova
kmova reviewed Aug 7, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pawanpraka1 pawanpraka1 changed the title chore(doc): adding volblocksize details in readme chore(doc): adding volume capacity roundoff details in readme Aug 7, 2020
@pawanpraka1 pawanpraka1 requested a review from w3aman August 8, 2020 17:02
kmova
kmova reviewed Aug 10, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@pawanpraka1
chore(doc): adding volume capacity roundoff details in readme
d4be900 
Signed-off-by: Pawan <pawan@mayadata.io>
@pawanpraka1 pawanpraka1 merged commit 22d2a0d into openebs:master Aug 10, 2020
@pawanpraka1 pawanpraka1 deleted the doc branch August 10, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmova kmova kmova approved these changes

@w3aman w3aman Awaiting requested review from w3aman

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@pawanpraka1 @codecov-commenter @kmova @w3aman