Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): Reverting back to old way of checking the volume status #196

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Aug 26, 2020

Signed-off-by: Pawan pawan@mayadata.io

Why is this PR required? What issue does it fix?:

few customers are using old version of the driver where
Status field is not present. So mount will fail after the
upgrade to the 0.9.1 or later version.

Reverting back to the checking if finalizer is set to check if
volume is ready to be mounted.

We need to support upgrade for alpha release until we offically announce it that we no longer support upgrade for alpha release.

Added this in #184

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@pawanpraka1 pawanpraka1 added the bug Something isn't working. label Aug 26, 2020
@pawanpraka1 pawanpraka1 added this to the v1.0.0 milestone Aug 26, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova August 26, 2020 15:15
few customers are using old version of the driver where
Status field is not present. So mount will fail after the
upgrade to the 0.9 or later version.

Reverting back to the checking if finalizer is set to check if
volume is ready to be mounted.

Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-commenter
Copy link

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #196   +/-   ##
======================================
  Coverage    9.88%   9.88%           
======================================
  Files          20      20           
  Lines        1163    1163           
======================================
  Hits          115     115           
  Misses       1047    1047           
  Partials        1       1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bb8aa...aff2af0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants