feat(zfspv): mounting the root filesystem to remove the dependency on the Operating system #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
changed the title
… the OS We are mounting the individual library to run the zfs binary inside the ZFS-LocalPV daemonset. The problem with this is each OS has different sets of libraries. We need to have different Operator yamls for different OS versions. Here we are mounting the root directory inside the ZFS-LocalPV daemonset Pod which does chroot to this path and run the command. As all the libraries will be available which are present on the host inside the Pod, so we don't need to mount each library here and also it will work for all the Operating systems. To be on the safe side, we are mounting the host's root directory as Readonly filesystem. Signed-off-by: Pawan <pawan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
======================================
Coverage 9.88% 9.88%
======================================
Files 20 20
Lines 1163 1163
======================================
Hits 115 115
Misses 1047 1047
Partials 1 1 Continue to review full report at Codecov.
|
prateekpandey14
approved these changes
Sep 4, 2020
|
Yes @prateekpandey14 , once we move e2e test cases to point to this yaml, I will cleanup other yamls. |
kmova
approved these changes
Sep 7, 2020
kmova
reviewed
Sep 7, 2020
Signed-off-by: Pawan <pawan@mayadata.io>
w3aman
approved these changes
Sep 7, 2020
7 tasks
This was referenced Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #202 and probably #72 also.
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
We are mounting the individual library to run the zfs
binary inside the ZFS-LocalPV daemonset. The problem with this
is each OS has different sets of libraries. We need to have different
Operator yamls for different OS versions.
What this PR does?:
Here we are mounting the root directory inside the ZFS-LocalPV daemonset Pod
which does chroot to this path and run the command. As all the libraries will
be available which are present on the host inside the Pod, so we don't need to mount each
library here and also it will work for all the Operating systems.
Any additional information for your reviewer? :
To be on the safe side, we are mounting the host's root directory
as Readonly filesystem. Will cleanup the centos yamls once we have migrated to this in e2e.
Thanks @jlcox1970 for helping me verify this change on CentOS 8.
Checklist:
<type>(<scope>): <subject>