Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mount): fixing idempotency check for the mount path #260

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Dec 15, 2020

Signed-off-by: Pawan pawan@mayadata.io

Why is this PR required? What issue does it fix?:

fixing idempotency check for the mount path

What this PR does?:

For shared mount, the idempotency check was not happening. So checking the mounts for shared volume also.

Does this PR require any upgrade changes?:

no

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #260 (0041017) into master (0409fca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #260   +/-   ##
======================================
  Coverage    7.70%   7.70%           
======================================
  Files          20      20           
  Lines        1155    1155           
======================================
  Hits           89      89           
  Misses       1065    1065           
  Partials        1       1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0409fca...0041017. Read the comment docs.

Signed-off-by: pawan <pawan@mayadata.io>
@kmova kmova merged commit bf939b0 into openebs:master Dec 15, 2020
@pawanpraka1 pawanpraka1 deleted the mount branch December 15, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants