Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(csi): use common lib-csi imports #263

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

shubham14bajpai
Copy link
Member

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:
This PR refactors the current code to use the openebs/lib-csi imports which are common among other implementations of CSI drivers.

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
go.mod Outdated Show resolved Hide resolved
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Member

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks for the quick PR @shubham14bajpai

@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label Dec 18, 2020
@pawanpraka1 pawanpraka1 added this to the 1.3.0 milestone Dec 18, 2020
@pawanpraka1 pawanpraka1 merged commit 2906d39 into openebs:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants