feat(resize): adding resize support for raw block volumes

changelogs/unreleased/281-pawanpraka1

@@ -0,0 +1 @@
+adding resize support for raw block volumes

pkg/driver/agent.go

@@ -17,6 +17,7 @@ limitations under the License.
 package driver
 
 import (
+	"os"
 	"strings"
 	"sync"
 
@@ -330,7 +331,23 @@ func (ns *node) NodeExpandVolume(
 			err.Error(),
 		)
 	}
-	if err = zfs.ResizeZFSVolume(vol, req.GetVolumePath()); err != nil {
+
+	// find if it is block device so that we don't attempt filesystem resize
+	st, err := os.Stat(req.GetVolumePath())
+	if err != nil {
+		return nil, status.Errorf(codes.Internal, "failed to stat mountpath %s", err.Error())
+	}
+
+	resizefs := false
+
+	// doing this dirty check as volume capabilities are not passed for NodeExpandVolume
+	// CSI 1.2 spec will probably solve this
+	if st.IsDir() {
+		// it is not a block device, resize the filesystem
+		resizefs = true
+	}
+
+	if err = zfs.ResizeZFSVolume(vol, req.GetVolumePath(), resizefs); err != nil {
 		return nil, status.Errorf(
 			codes.Internal,
 			"failed to handle NodeExpandVolume Request for %s, {%s}",

pkg/zfs/zfs_util.go

@@ -703,7 +703,7 @@ func GetVolumeDevPath(vol *apis.ZFSVolume) (string, error) {
 }
 
 // ResizeZFSVolume resize volume
-func ResizeZFSVolume(vol *apis.ZFSVolume, mountpath string) error {
+func ResizeZFSVolume(vol *apis.ZFSVolume, mountpath string, resizefs bool) error {
 
 	volume := vol.Spec.PoolName + "/" + vol.Name
 	args := buildVolumeResizeArgs(vol)
@@ -717,7 +717,11 @@ func ResizeZFSVolume(vol *apis.ZFSVolume, mountpath string) error {
 		return err
 	}
 
-	err = handleVolResize(vol, mountpath)
+	if resizefs == true {
+		// resize the filesystem so that applications can use the expanded space
+		err = handleVolResize(vol, mountpath)
+	}
+
 	return err
 }