fix(topo): support old topology key for backward compatibility #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
older version of velero uses
openebs.io/nodenameto set the affinity on the PV. To support backward compatibility, ZFS-LocalPV needs to supportopenebs.io/nodenameas topology key.The issue is there if someone is using old velero and did a fresh installation of ZFS-LocalPV, in that case velero will try to use the affinity key
openebs.io/nodenamebut that will not be present on the node and pod will not be scheduled.If someone was using old version of ZFS-LocalPV and upgraded to this new release, he will not face any issue as
openebs.io/nodenamewill still be present and pod can be scheduled successfully.