Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): Bump golang, k8s and lib-csi versions #444

Merged
merged 1 commit into from
May 28, 2023

Conversation

shubham14bajpai
Copy link
Member

What this PR does?:

This PR updates the following components:

  • go: 1.19.9
  • k8s: v1.27.2
  • klog: v2
  • lib-csi: v0.7.0

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this change. Might be a good idea to remove the vendor directory.
This entails few other minor changes:

  • Github actions workflows exclusions
  • Makefile -mod=vendor to -mod=mod options. Removing the module paths' 'vendor/' prefix.
  • makefile grep command exclusions

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to switch out github.com/ghodss/yaml with sigs.k8s.io/yaml@v1.3.0

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to switch out github.com/ghodss/yaml with sigs.k8s.io/yaml@v1.3.0

- go: 1.19.9
- k8s: v1.27.2
- klog: v2
- lib-csi: v0.7.0

Signed-off-by: shubham <shubham14bajpai@gmail.com>
@niladrih niladrih merged commit c0343d0 into openebs:develop May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants