Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin): Fix ability to have custom value for openebs.io/nodeid #451

Merged
merged 7 commits into from
Dec 20, 2023
Merged

fix(plugin): Fix ability to have custom value for openebs.io/nodeid #451

merged 7 commits into from
Dec 20, 2023

Commits on Nov 29, 2023

  1. fix(plugin): fix node id to node mapping 

    Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
    @jnels124 @hrudaya21
    jnels124 authored and hrudaya21 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    d0f018f View commit details
    Browse the repository at this point in the history

  2. add change log 

    Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
    @jnels124 @hrudaya21
    jnels124 authored and hrudaya21 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e424c32 View commit details
    Browse the repository at this point in the history

  3. fix case when nodeid not set 

    Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
    @jnels124 @hrudaya21
    jnels124 authored and hrudaya21 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    bd689b3 View commit details
    Browse the repository at this point in the history

  4. simplify logic 

    Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
    @jnels124 @hrudaya21
    jnels124 authored and hrudaya21 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5715846 View commit details
    Browse the repository at this point in the history

  5. update doc 

    Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
    @jnels124 @hrudaya21
    jnels124 authored and hrudaya21 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    704698c View commit details
    Browse the repository at this point in the history

  6. fix cases where nodeid not set 

    Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
    @jnels124 @hrudaya21
    jnels124 authored and hrudaya21 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    3e76974 View commit details
    Browse the repository at this point in the history

  7. check for error first 

    Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
    @jnels124 @hrudaya21
    jnels124 authored and hrudaya21 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1058228 View commit details
    Browse the repository at this point in the history