feat(zfspv): adding poolname info to the PV volumeattributes #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now PV will have poolname/parent-dataset info in volume attributes.
It will help to identify that PV has been create in which zpool.
```
$ kubectl describe pv pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7
Name: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7
Labels: <none>
Annotations: pv.kubernetes.io/provisioned-by: zfs.csi.openebs.io
Finalizers: [kubernetes.io/pv-protection]
StorageClass: openebs-zfspv
Status: Bound
Claim: default/pvcname208
Reclaim Policy: Delete
Access Modes: RWO
VolumeMode: Filesystem
Capacity: 4Gi
Node Affinity:
Required Terms:
Term 0: kubernetes.io/hostname in [pawan-2]
Message:
Source:
Type: CSI (a Container Storage Interface (CSI) volume source)
Driver: zfs.csi.openebs.io
VolumeHandle: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7
ReadOnly: false
VolumeAttributes: openebs.io/poolname=zfspv-pool
storage.kubernetes.io/csiProvisionerIdentity=1586765686638-8081-zfs.csi.openebs.io
Events: <none>
```
Signed-off-by: Pawan <pawan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 23.57% 23.57%
=======================================
Files 14 14
Lines 475 475
=======================================
Hits 112 112
Misses 362 362
Partials 1 1 Continue to review full report at Codecov.
|
kmova
reviewed
Apr 13, 2020
kmova
approved these changes
Apr 14, 2020
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Apr 14, 2020
) Now PV will have poolname/parent-dataset info in volume attributes to help to identify the zpool on which PV has been created. ``` $ kubectl describe pv pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7 Name: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7 Labels: <none> Annotations: pv.kubernetes.io/provisioned-by: zfs.csi.openebs.io Finalizers: [kubernetes.io/pv-protection] StorageClass: openebs-zfspv Status: Bound Claim: default/pvcname208 Reclaim Policy: Delete Access Modes: RWO VolumeMode: Filesystem Capacity: 4Gi Node Affinity: Required Terms: Term 0: kubernetes.io/hostname in [pawan-2] Message: Source: Type: CSI (a Container Storage Interface (CSI) volume source) Driver: zfs.csi.openebs.io VolumeHandle: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7 ReadOnly: false VolumeAttributes: openebs.io/poolname=zfspv-pool storage.kubernetes.io/csiProvisionerIdentity=1586765686638-8081-zfs.csi.openebs.io Events: <none> ``` Signed-off-by: Pawan <pawan@mayadata.io>
Merged
kmova
pushed a commit
that referenced
this pull request
Apr 14, 2020
Now PV will have poolname/parent-dataset info in volume attributes to help to identify the zpool on which PV has been created.
```
$ kubectl describe pv pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7
Name: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7
Labels: <none>
Annotations: pv.kubernetes.io/provisioned-by: zfs.csi.openebs.io
Finalizers: [kubernetes.io/pv-protection]
StorageClass: openebs-zfspv
Status: Bound
Claim: default/pvcname208
Reclaim Policy: Delete
Access Modes: RWO
VolumeMode: Filesystem
Capacity: 4Gi
Node Affinity:
Required Terms:
Term 0: kubernetes.io/hostname in [pawan-2]
Message:
Source:
Type: CSI (a Container Storage Interface (CSI) volume source)
Driver: zfs.csi.openebs.io
VolumeHandle: pvc-22d55c56-0c52-4fd5-894c-1f54c4dac5b7
ReadOnly: false
VolumeAttributes: openebs.io/poolname=zfspv-pool
storage.kubernetes.io/csiProvisionerIdentity=1586765686638-8081-zfs.csi.openebs.io
Events: <none>
```
Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now PV will have poolname/parent-dataset info in volume attributes.
It will help to identify that PV has been create in which zpool.
Signed-off-by: Pawan pawan@mayadata.io