Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add PII annotations #274

Merged
merged 2 commits into from
Nov 27, 2024
Merged

docs: Add PII annotations #274

merged 2 commits into from
Nov 27, 2024

Conversation

bmtcril
Copy link

@bmtcril bmtcril commented Nov 22, 2024

Per OEP-30 these annotations should live with the project that defines the models. I'm moving them here so we can remove them from edx-platform.

As these PRs are mostly updating comments I'm generally not version bumping or suggesting releases for them.

Per OEP-30 these annotations should live with the project that defines
the models. I'm moving them here so we can remove them from
edx-platform.
@bmtcril bmtcril changed the title docs: Add PII annotations docs: Add PII annotations, remove Python 3.8 and add 3.12 Nov 22, 2024
Copy link

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion that you can take or leave.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@bmtcril bmtcril force-pushed the bmtcril/pii_annotations branch 2 times, most recently from ebb19df to e13425f Compare November 25, 2024 19:08
@bmtcril
Copy link
Author

bmtcril commented Nov 25, 2024

I'm dropping the 3.8 - 3.12 commit in favor of the existing PR, which is more thorough.

@openedx/2u-aperture would you like to review as the maintainers?

wiki/models/article.py Outdated Show resolved Hide resolved
Copy link

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with just one piece where I wasn't sure if I was misunderstanding what was being stated. Thanks for this!

@bmtcril bmtcril changed the title docs: Add PII annotations, remove Python 3.8 and add 3.12 docs: Add PII annotations Nov 27, 2024
@bmtcril bmtcril merged commit 0eac172 into edx_release Nov 27, 2024
4 checks passed
@bmtcril bmtcril deleted the bmtcril/pii_annotations branch November 27, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants