Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OldMongo FC-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split #30955

Conversation

UvgenGen
Copy link
Contributor

@UvgenGen UvgenGen commented Sep 7, 2022

Description

Removed code related to Old -> Split migration + re-running Old Mongo courses as Split

  • Mgmt cmd removed from edx-platform
  • course_clone function altered to support only split versioning courses
  • Split migrator is removed
  • related tests are removed

Useful information to include:
openedx/public-engineering#76
depends on:
#30933

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 7, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 7, 2022

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link
Contributor

natabene commented Sep 7, 2022

@UvgenGen Thank you for your contribution. @ormsbee FYI this PR.

@UvgenGen UvgenGen changed the title [WIP] DEPR Remove code related to Old -> Split migration + re-running Old Mongo courses as Split [WIP] [Fc-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split Sep 7, 2022
@UvgenGen UvgenGen changed the title [WIP] [Fc-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split [WIP] [OldMongo FC-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split Sep 7, 2022
@ormsbee ormsbee self-requested a review September 9, 2022 00:41
@ormsbee ormsbee changed the title [WIP] [OldMongo FC-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split [OldMongo FC-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split Sep 9, 2022
Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, after #30933 merges and this can be rebased on top of that. Not planning to merge either until next week.

@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG_remove_old_to_split_migration branch from 2bf3d37 to 6cb40e7 Compare September 14, 2022 14:39
@UvgenGen
Copy link
Contributor Author

@ormsbee PR already rebased on the top of #30933)

@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG_remove_old_to_split_migration branch from 6cb40e7 to 6a9970d Compare September 14, 2022 15:44
Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but two requests:

  1. Please squash the commits and make a new commit message giving more context.
  2. The only possible way I could see this causing a regression to existing code is when re-running Split courses. Has that been manually tested just to verify it still works as expected?

Once this is done, I plan to merge this Monday morning.

FYI @jristau1984

@UvgenGen UvgenGen force-pushed the sagirov/EDXOLDMNG_remove_old_to_split_migration branch from 6a9970d to 25aa271 Compare September 16, 2022 07:45
@UvgenGen
Copy link
Contributor Author

@ormsbee I squashed the commits. I checked re-running Split courses and it works as expected.

@ormsbee ormsbee merged commit 42246c8 into openedx:master Sep 19, 2022
@openedx-webhooks
Copy link

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants