-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OldMongo FC-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split #30955
[OldMongo FC-0004] Remove code related to Old -> Split migration + re-running Old Mongo courses as Split #30955
Conversation
Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, after #30933 merges and this can be rebased on top of that. Not planning to merge either until next week.
2bf3d37
to
6cb40e7
Compare
6cb40e7
to
6a9970d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but two requests:
- Please squash the commits and make a new commit message giving more context.
- The only possible way I could see this causing a regression to existing code is when re-running Split courses. Has that been manually tested just to verify it still works as expected?
Once this is done, I plan to merge this Monday morning.
FYI @jristau1984
…Mongo courses as Split
6a9970d
to
25aa271
Compare
@ormsbee I squashed the commits. I checked re-running Split courses and it works as expected. |
@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Description
Removed code related to Old -> Split migration + re-running Old Mongo courses as Split
Useful information to include:
openedx/public-engineering#76
depends on:
#30933