Paver Removal 3/3 #34832
Draft
Paver Removal 3/3 #34832
+136
−2,244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
Closed
Merged
Open
kdmccormick
force-pushed
the
kdmccormick/paver-rm-3
branch
3 times, most recently
from
8d2f898 to
b62342d
Compare
kdmccormick
force-pushed
the
kdmccormick/paver-rm-3
branch
from
fec76ab to
95cb5ce
Compare
BREAKING CHANGE: Removes all remaining Paver commands including `pavelib/prereqs.py:*` and `pavelib/assets.py:*`. BREAKING CHANGE: Removes `./manage.py [lms|cms] compile_sass`, which was just a wrapper around Paver commands. BREAKING CHANGE: Removes paver.txt. Operators should install testing.txt instead. Part of: openedx#34467
These packages were installed transitively through paver.in, but they are used as direct dependencies in edx-platform application code: * psutil * pymemcache * wrapt Since we are demoting paver.in to be a dev-only dependency (with plans to remove paver.in entirely), we need to make those three packages explicit dependencies in kernel.in Part of: openedx#34467
BREAKING CHANGE: Removes libsass from requirements/edx/base.txt. Operators will need to install requirements/edx/assets.txt in order to compile Sass. Commit generated by workflow `kdmccormick/edx-platform/.github/workflows/compile-python-requirements.yml@refs/heads/master`
kdmccormick
force-pushed
the
kdmccormick/paver-rm-3
branch
from
95cb5ce to
563e1cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pavelib/prereqs.py:*pavelib/assets.py:*./manage.py [lms|cms] compile_sass, which was just a wrapper around Paver commands.Supporting information
This plan has been accepted and communicated via the DEPR process:
Previous PRs (blocking this one):
Paver Removal 2/3 #34830Testing instructions
I built the Tutor openedx and openedx-dev images with this branch. I smoke tested LMS and CMS in both modes, and ensure that I could toggle between Indigo and the default theme.