Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WH] Deduplicate configuration #18

Closed
timmc-edx opened this issue Aug 3, 2022 · 2 comments
Closed

[WH] Deduplicate configuration #18

timmc-edx opened this issue Aug 3, 2022 · 2 comments
Assignees
Labels
event-bus Work related to the Event Bus.

Comments

@timmc-edx
Copy link
Contributor

The producer and consumer code in event-bus-kafka both currently load the same config settings and create a schema registry client in the same way. These should be deduplicated into a config.py or something.

@timmc-edx
Copy link
Contributor Author

I was playing around with some code for this: main...common-config Whoever picks this up, feel free to use that code or not. (The attrs thing might be overkill. Might just want a dict with string keys or whatever.)

@timmc-edx timmc-edx added event-bus Work related to the Event Bus. backlog Item is on a team's backlog or wish list. labels Aug 3, 2022
@timmc-edx timmc-edx moved this to Todo in Arch-BOM Aug 3, 2022
@robrap robrap removed the backlog Item is on a team's backlog or wish list. label Aug 3, 2022
@robrap robrap moved this from Todo to Groomed in Arch-BOM Aug 4, 2022
@robrap robrap moved this from Groomed to In Progress in Arch-BOM Aug 4, 2022
@robrap
Copy link
Contributor

robrap commented Aug 10, 2022

Implementation PR: #20

@whuang1202 whuang1202 moved this from In Progress to Done in Arch-BOM Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-bus Work related to the Event Bus.
Projects
None yet
Development

No branches or pull requests

3 participants