feat: remove optimizely event #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 86.99% 86.96% -0.03%
==========================================
Files 124 124
Lines 2269 2264 -5
Branches 626 624 -2
==========================================
- Hits 1974 1969 -5
Misses 286 286
Partials 9 9
☔ View full report in Codecov by Sentry. |
mubbsharanwar
approved these changes
Aug 30, 2023
zainab-amir
force-pushed
the
zamir/remove_optimizely_event
branch
from
89ca183 to
6ab31c9
Compare
mubbsharanwar
approved these changes
Sep 12, 2023
snglth
pushed a commit
to Abstract-Tech/community-theme-authn
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the optimizely event and registration conversion cookie (this was used in GTM and added the same optimizely event).
NOTE: This will be merged once I get confirmation from Gabe that GTM has been updated to use the newly added segment event for registration conversion:
edx.bi.user.account.registered.clientJIRA
VAN-1624
How Has This Been Tested?
Updated test