fix: the display of username suggestions

[khudym]

Description

Username suggestions functionality has been corrected to ensure proper behaviour.

• fixed issue with suggestions being displayed in the wrong place;
• added the ability to navigate through suggestions using the keyboard.

Related Pull Requests
PR to the open-release/redwood.master branch: #1279
PR to the open-release/quince.master branch: #1278

Steps to Reproduce:

1. suggestions being displayed in the wrong place

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> Click on field "Public username"

suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> press Tab button until you get to the "Public username" field

suggestions_keyboard.mov

After changes:

1. suggestions being displayed in the wrong place

fixed_suggestions_rendering_bug.mov

2. impossible to enter suggestions field using the keyboard

fixed_suggestions_keyboard.mov

Merge Checklist

• If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
• Is there adequate test coverage for your changes?

Post-merge Checklist

• Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[openedx-webhooks]

Thanks for the pull request, @khudym!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (52c6efc) to head (df13dc6).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   87.94%   87.69%   -0.25%     
==========================================
  Files         139      124      -15     
  Lines        2812     2300     -512     
  Branches      839      647     -192     
==========================================
- Hits         2473     2017     -456     
+ Misses        324      274      -50     
+ Partials       15        9       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mphilbrick211]

Friendly follow-up on this, @openedx/2u-vanguards. Thanks!

[mphilbrick211]

Hi @openedx/vanguards @openedx/2u-vanguards! I think you are still maintainers of this repo. Just checking in to see if someone could please take a look here?

[ihor-romaniuk]

Hello everyone,
It seems our pull request for the fix might be a bit stuck in the review process. Would someone be able to take a look at it when they have a moment?
Thank you so much for your time and help!

[mphilbrick211]

Hello everyone, It seems our pull request for the fix might be a bit stuck in the review process. Would someone be able to take a look at it when they have a moment? Thank you so much for your time and help!

@openedx/2u-infinity flagging this for you.