Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Switch to ubuntu-latest for builds #1316

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Sep 9, 2024

This code does not have any dependencies that are specific to any specific
version of ubuntu. So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.

This work is being done as a part of openedx/platform-roadmap#377

closes #1299

@feanil feanil requested a review from a team as a code owner September 9, 2024 14:00
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (6ffa45f) to head (439b916).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files         124      124           
  Lines        2299     2299           
  Branches      646      646           
=======================================
  Hits         2016     2016           
  Misses        274      274           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feanil feanil enabled auto-merge September 13, 2024 13:34
@feanil feanil requested review from brian-smith-tcril and a team September 13, 2024 13:34
This code does not have any dependencies that are specific to any specific
version of ubuntu.  So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.

This work is being done as a part of openedx/platform-roadmap#377

closes #1299
@feanil feanil force-pushed the feanil/ubuntu_upgrade branch from 30f208e to 439b916 Compare September 20, 2024 14:25
@feanil feanil requested a review from a team as a code owner September 20, 2024 14:25
@feanil feanil merged commit 6cb4b79 into master Sep 20, 2024
7 checks passed
@feanil feanil deleted the feanil/ubuntu_upgrade branch September 20, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test frontend-app-authn on Ubuntu 24.04
2 participants