Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ts* files to cov report #1155

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Jul 12, 2024

Description

Updates frontend-build package to add ts* files to coverage report

More info

Check the Indirect Changes from the coverage report of this branch to check the ts files added.

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 12, 2024

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 12, 2024
@rpenido rpenido force-pushed the rpenido/fal-3777-add-typescript-files-to-coverage branch from cfddd3d to a9c52d5 Compare July 12, 2024 14:22
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (3a14141) to head (78b5ae3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
+ Coverage   92.68%   92.84%   +0.16%     
==========================================
  Files         693      745      +52     
  Lines       12346    13384    +1038     
  Branches     2661     2860     +199     
==========================================
+ Hits        11443    12427     +984     
- Misses        872      922      +50     
- Partials       31       35       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpenido rpenido force-pushed the rpenido/fal-3777-add-typescript-files-to-coverage branch 4 times, most recently from 57fd09d to e99a176 Compare July 19, 2024 19:34
@rpenido rpenido force-pushed the rpenido/fal-3777-add-typescript-files-to-coverage branch 2 times, most recently from d7af9ea to 78b5ae3 Compare July 23, 2024 21:12
@rpenido rpenido marked this pull request as ready for review July 23, 2024 21:32
@rpenido rpenido requested a review from a team as a code owner July 23, 2024 21:32
@bradenmacdonald bradenmacdonald force-pushed the rpenido/fal-3777-add-typescript-files-to-coverage branch from 78b5ae3 to 0878826 Compare July 24, 2024 21:33
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this so I could test it, then tested it in dev mode as well as npm run build. Everything seems fine.

@bradenmacdonald bradenmacdonald enabled auto-merge (squash) July 24, 2024 21:40
@bradenmacdonald bradenmacdonald merged commit f159b2b into openedx:master Jul 24, 2024
5 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3777-add-typescript-files-to-coverage branch July 24, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants