Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "test: Remove support for Node 18 (#736)" #740

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

This reverts commit dc5f097. Node 18 removal PRs should be merged after Sumac is cut.

This reverts commit dc5f097. Node 18 removal PRs should be merged after Sumac is cut.
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (dc5f097) to head (b794395).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #740   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         161      161           
  Lines        3404     3404           
  Branches      919      924    +5     
=======================================
  Hits         3172     3172           
  Misses        214      214           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@brian-smith-tcril brian-smith-tcril merged commit 472bbe2 into openedx:master Oct 22, 2024
7 checks passed
brian-smith-tcril added a commit to brian-smith-tcril/frontend-app-discussions that referenced this pull request Oct 31, 2024
brian-smith-tcril added a commit to brian-smith-tcril/frontend-app-discussions that referenced this pull request Oct 31, 2024
brian-smith-tcril added a commit to brian-smith-tcril/frontend-app-discussions that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants