-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clicking on back button after post creation #745
base: master
Are you sure you want to change the base?
fix: clicking on back button after post creation #745
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 93.17% 93.18%
=======================================
Files 161 161
Lines 3401 3402 +1
Branches 919 920 +1
=======================================
+ Hits 3169 3170 +1
+ Misses 215 214 -1
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. |
Hi @openedx/2u-infinity! This is ready for review. |
Description
Steps to Reproduce:
Open course in LMS
Open discussions sidebar
Add post -> Submit
Click on back browser button
Result
Result of the investigation:
Found that
post id
is unpacked when saving to state, although it should be saved intact:After fixing the unpacking, this error also started to occur:
I have added a check that the post exists to fix this situation: