Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: removed usage of subs catalog consolidation feature flag #375

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

mahamakifdar19
Copy link
Contributor

Description

  • Removed usage of feature flag introduced here since it is obsolete and we have merged the sub catalogs (business and education) into Subscription.
  • Code cleanup for education sub catalog

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 force-pushed the mahamakif/ENT-8297 branch 2 times, most recently from d88c587 to 139089e Compare February 12, 2024 10:13
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (975df0b) 82.29% compared to head (1c77686) 83.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   82.29%   83.21%   +0.91%     
==========================================
  Files          38       38              
  Lines         706      685      -21     
  Branches      228      211      -17     
==========================================
- Hits          581      570      -11     
+ Misses        121      111      -10     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good! If you're going to be removing all references to the education catalog there's a couple more things: the EDX_FOR_ONLINE_EDU_TITLE and all the education related messages.js files in CatalogSelectionDeck, CatalogSearchResults, CourseCard, and ProgramCard

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mahamakifdar19 mahamakifdar19 merged commit a2a2ece into main Feb 13, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the mahamakif/ENT-8297 branch February 13, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants