-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: removed usage of subs catalog consolidation feature flag #375
Conversation
d88c587
to
139089e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 82.29% 83.21% +0.91%
==========================================
Files 38 38
Lines 706 685 -21
Branches 228 211 -17
==========================================
- Hits 581 570 -11
+ Misses 121 111 -10
Partials 4 4 ☔ View full report in Codecov by Sentry. |
139089e
to
6098d3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good! If you're going to be removing all references to the education catalog there's a couple more things: the EDX_FOR_ONLINE_EDU_TITLE and all the education related messages.js files in CatalogSelectionDeck, CatalogSearchResults, CourseCard, and ProgramCard
6098d3b
to
1c77686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
For all changes
Only if submitting a visual change