test: Remove support for Node 18 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 157 157
Lines 1387 1387
Branches 229 229
=======================================
Hits 1351 1351
Misses 34 34
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
I'm not formally blocking this because the constraint is 2U-only, but Aperture won't be progressing this until the work to enable deploying node 20 in our environment is complete. |
deborahgu
added
the
waiting for eng review
jsnwesson
approved these changes
Sep 6, 2024
|
@BilalQamar95 I just learned that there was a decision to hold off on removing Node 18 support until after the Sumac cut. Once Sumac is cut, then these PRs to remove Node 18 support can be merged. |
justinhynes
previously approved these changes
Sep 12, 2024
justinhynes
dismissed
their stale review
didn't see the conflict before I accepted the changes, d'oh, then I saw jason's message too (double d'oh)
deborahgu
removed
the
waiting for eng review
brian-smith-tcril
approved these changes
Oct 31, 2024
jciasenza
pushed a commit
to jciasenza/frontend-app-learner-dashboard
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Jason Wesson <jsnwesson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: As per openedx/public-engineering#280 this can merge after Sumac cut.
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrcfor version to use.See the tracking issue for further information.