feat(AU-2115): use ATLAS_OPTIONS for pull_translations command #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-smith-tcril
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Great catch! Thank you so much for this PR!
It seems the CI failure is unrelated to this PR so we can disregard that.
I would like to request the changes to the .json files in src/i18n/messages be reverted, as those files are pulled from the openedx-translations repo via atlas at build time instead.
brian-smith-tcril
approved these changes
Jul 3, 2024
|
@brian-smith-tcril thank you for jumping in and check my PR. I'm not familiar with the fork process here, how can I get this merged ? I don't have write access. |
|
@brian-smith-tcril still waiting for this to be merged since I don't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.