From 567a11bbb4a82514d6da8534b6f6cd9fa9f8631b Mon Sep 17 00:00:00 2001 From: hajorg Date: Tue, 3 Dec 2024 17:03:44 +0100 Subject: [PATCH 1/3] fix: resolve ORA peer review issue --- src/components/StepProgressIndicator/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/StepProgressIndicator/index.jsx b/src/components/StepProgressIndicator/index.jsx index 062dc311..b06a333b 100644 --- a/src/components/StepProgressIndicator/index.jsx +++ b/src/components/StepProgressIndicator/index.jsx @@ -53,7 +53,7 @@ const StepProgressIndicator = ({ step }) => { && !(step === stepNames.peer && stepInfo[step].isWaitingForSubmissions) && !(step === stepNames.studentTraining && needed === done); - if (stepNames.peer === step && done >= needed) { + if (showAction && stepNames.peer === step && done >= needed) { loadNextAction.action.labels.default = formatMessage(messages.gradeNextPeerOptional); } return ( From 4a9eb0e32bb8a314da1cda96b57c9e6ee13c6f6f Mon Sep 17 00:00:00 2001 From: hajorg Date: Wed, 4 Dec 2024 14:13:56 +0100 Subject: [PATCH 2/3] fix: resolve visual glitch with validateBeforeConfirmation function --- src/views/SubmissionView/hooks/useSubmissionValidationStatus.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/views/SubmissionView/hooks/useSubmissionValidationStatus.js b/src/views/SubmissionView/hooks/useSubmissionValidationStatus.js index 9ce9c618..a2265eb8 100644 --- a/src/views/SubmissionView/hooks/useSubmissionValidationStatus.js +++ b/src/views/SubmissionView/hooks/useSubmissionValidationStatus.js @@ -35,8 +35,8 @@ const useSubmissionStatuses = (textResponses, uploadedFiles) => { } const calcFileUploadIsRequired = submissionConfig.fileResponseConfig.required && !uploadedFiles.length; setFileUploadIsRequired(calcFileUploadIsRequired); + setPromptStatuses(retrievePromptsSubmissionStatus); if (containsInvalidPrompts || (submissionConfig.fileResponseConfig.required && !uploadedFiles.length)) { - setPromptStatuses(retrievePromptsSubmissionStatus); return false; } From 5f8abfe73ab0db28027f5d056b85c9138e53c62a Mon Sep 17 00:00:00 2001 From: hajorg Date: Thu, 5 Dec 2024 16:01:03 +0100 Subject: [PATCH 3/3] fix: update StepProgressIndicator Component --- src/components/StepProgressIndicator/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/StepProgressIndicator/index.jsx b/src/components/StepProgressIndicator/index.jsx index b06a333b..685b0c18 100644 --- a/src/components/StepProgressIndicator/index.jsx +++ b/src/components/StepProgressIndicator/index.jsx @@ -53,7 +53,7 @@ const StepProgressIndicator = ({ step }) => { && !(step === stepNames.peer && stepInfo[step].isWaitingForSubmissions) && !(step === stepNames.studentTraining && needed === done); - if (showAction && stepNames.peer === step && done >= needed) { + if (loadNextAction?.action && stepNames.peer === step && done >= needed) { loadNextAction.action.labels.default = formatMessage(messages.gradeNextPeerOptional); } return (