Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization scoped events #196

Closed
1 task
mariajgrimaldi opened this issue Apr 4, 2023 · 6 comments
Closed
1 task

Organization scoped events #196

mariajgrimaldi opened this issue Apr 4, 2023 · 6 comments

Comments

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Apr 4, 2023

Description

This issue serves as a starting point for the discussion mentioned during the Open edX Events guide pull request, saying organization proprietary events might live in this repo as well.

Original comment: #80 (comment)

Tasks

  1. documentation
@robrap
Copy link
Contributor

robrap commented Jul 12, 2023

@ormsbee: Without you bringing up this topic (and I lost where you originally mentioned this), I probably would have just created something like a 2u-events repo. Either way, I'd probably use 2u namespaced event types.

Are you still imagining that orgs should be able to add to this repo, and if so, can you add some of your thoughts here? Ultimately, this could turn in to an ADR for deciding for or against it.

Additionally, were you thinking of this only for events that are produced within an open source repo, or even if it may be produced from a private repo? Either way, we'll need to choose whether it makes sense (or is a problem) to make the private events public.

Note: There is a separate licensing issue documented #184, but I'm hopeful that that can quickly be resolved.

@mariajgrimaldi
Copy link
Member Author

@robrap: I'm not sure whether this discussion happened elsewhere, but I created an issue documenting how to create organization-specific events for now. The docs will explain that if events are org or client-specific, then create their definitions in your repository. I've seen people do that, but I don't know if we're doing it to keep it as the standard. At least it's working for the time being.

@robrap
Copy link
Contributor

robrap commented Jun 25, 2024

Thanks @mariajgrimaldi. This was really started on behalf of @ormsbee, so I'm hoping he can respond or close the ticket.

UPDATE: If you don't hear back after some time, feel free to close.

@ormsbee
Copy link

ormsbee commented Jun 25, 2024

Thanks folks. I totally forgot about this ticket, and I honestly don't remember the discussion that we had around this.

I think my take was that org-specific events should not live in openedx-events, but that it should be possible for orgs to import everything that they would need to create their own events from openedx-events (i.e. declare instances of OpenEdxPublicSignal in their own repos).

But honestly, I've been out of the loop of openedx-events for a while now, so I have no idea where conversations around that have gone in the last year.

@robrap
Copy link
Contributor

robrap commented Jun 25, 2024

Ok. I think I must have misunderstood you long ago, so I am going to close this ticket. Thank you all!

@robrap robrap closed this as completed Jun 25, 2024
@mariajgrimaldi
Copy link
Member Author

Thank you both! Still, I'll include Dave's comments in the documentation since they're helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants