Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #935

Open
6 tasks
Tracked by #274
irtazaakram opened this issue Sep 10, 2024 · 4 comments
Open
6 tasks
Tracked by #274

Drop support for Python 3.8 #935

irtazaakram opened this issue Sep 10, 2024 · 4 comments
Labels
maintenance Routine upkeep necessary for the health of the platform

Comments

@irtazaakram
Copy link
Member

Description:

Follow and complete all of the following steps for the issue to be marked as done.

  • Update the tox.ini, setup.py, setup.cfg, or pyproject.toml to remove Python 3.8 from the supported versions list.
  • Ensure the GitHub Actions workflows are updated, particularly removing Python 3.8 from the CI matrix.
  • Review and clean up any testing or build configurations referencing Python versions earlier than 3.11.
  • Run tests in the CI to ensure everything passes after removing Python 3.8.
  • Add a CHANGELOG entry: “Dropped support for Python 3.8.”
  • Bump the package version and release a new version on GitHub & PyPI (if applicable).
@irtazaakram irtazaakram added the maintenance Routine upkeep necessary for the health of the platform label Sep 10, 2024
@bmtcril
Copy link
Contributor

bmtcril commented Sep 17, 2024

I'm marking this as blocked for now, we need to support Py 3.8 until we do the breaking 2.0 release of Aspects (around Sumac launch) since 1.x supports back to Nutmeg.

@Ian2012
Copy link
Contributor

Ian2012 commented Sep 19, 2024

@bmtcril this change would only affect the environment were the plugin is installed, right?

So this would require bumping the minimum tutor version required.

@bmtcril
Copy link
Contributor

bmtcril commented Sep 20, 2024

It's kind of complicated since we run code in so many environments:

  • Our own Aspects container (should already be upgraded?)
  • Superset (running 3.10, not sure if we're actually testing much of that code now, or what version we're using off hand)
  • Whatever is running Tutor commands, for testing those yes I think we'd need to bump our Tutor version, which we should do for a breaking 2.0 change anyway

@Ian2012
Copy link
Contributor

Ian2012 commented Sep 30, 2024

Before I forget it, we should also delete the v0_commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Routine upkeep necessary for the health of the platform
Projects
Status: Blocked
Development

No branches or pull requests

3 participants