-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: feat: add patches needed for local and k8s usage #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add patches necessary to add coursegraph to k8s configuration files, as well as caddyfile (which is used by both k8s and local deployments)).
still fails to establish db connection, although bolt proxying seems to work need to update tests and readme with new settings
kdmccormick
force-pushed
the
kdmccormick/k8s
branch
from
March 22, 2022 18:24
b28fb85
to
ba45d46
Compare
this work in k8s mode but will break in local mode
kdmccormick
force-pushed
the
kdmccormick/k8s
branch
from
March 22, 2022 18:25
ba45d46
to
96c4f54
Compare
this allows us to consolidate production and dev settings and should fix local mode (needs testing still) without adding additional funky configuration. also, defer to ENABLE_HTTPS, dropping COURSEGRAPH_NEO4J_BOLT_SECURE and simplifying caddyfile. also, document caddyfile. test-install.sh and README.rst still need updating
kdmccormick
force-pushed
the
kdmccormick/k8s
branch
from
March 23, 2022 01:45
9b61180
to
9da8ef4
Compare
kdmccormick
force-pushed
the
kdmccormick/k8s
branch
from
March 23, 2022 01:46
9da8ef4
to
7d32394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patches necessary to add coursegraph to k8s configuration
files, as well as caddyfile (which is used by both k8s and
local deployments)).