Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for gcc while building OE SDK from source #3555

Closed
radhikaj opened this issue Sep 17, 2020 · 1 comment
Closed

Deprecate support for gcc while building OE SDK from source #3555

radhikaj opened this issue Sep 17, 2020 · 1 comment
Assignees
@radhikaj
Labels
build Issue is related to the build system ci/cd Issue is related to the code integration/deployment pipeline devtools Issue is related to Open Enclave SDK tools and debugging documentation Issue describes the need for updated or additional documentation for the repo or SDK SGX Tag indicating associated with Intel SGX triaged This label classifies an issue/PR as having been triaged.

Comments

@radhikaj
Copy link
Contributor

radhikaj commented Sep 17, 2020 •
edited
Loading

  1. Our developer docs state that developers should use clang while building from source
  2. clang provides spectre mitigations while gcc(On Ubuntu 1604) does not.

What deprecation would mean

  1. We remove CI support for building the SDK with gcc from source
  2. Update docs to say that we only recommend building with clang while building the SDK from source.

From Sig-arch this morning

  1. We will issue a notice of deprecation for gcc support in v0.11 but stop supporting it after v0.12.
  2. In the docs, we will clarify that we recommend building with clang with the spectre mitigations. We will not prevent developers from building with a compiler of their choice.
  3. After v0.12, we will remove support from CI
  4. We should revisit what version of clang we can support. See issue: Standardize clang-8 support for OE SDK #2476, added to SIG-Arch agenda

Please note:
Samples are built and tested against gcc and Clang today and this will remain so even after v0.12. Developers can continue to use the compiler of their choice while building applications.
@radhikaj radhikaj added devtools Issue is related to Open Enclave SDK tools and debugging ci/cd Issue is related to the code integration/deployment pipeline labels Sep 17, 2020
@mingweishih mingweishih added build Issue is related to the build system documentation Issue describes the need for updated or additional documentation for the repo or SDK labels Sep 17, 2020
@radhikaj radhikaj added the triaged This label classifies an issue/PR as having been triaged. label Sep 21, 2020
@radhikaj radhikaj self-assigned this Sep 21, 2020
@anakrish anakrish mentioned this issue Sep 22, 2020
Closed
This was referenced Sep 22, 2020
Closed
Merged
bors bot pushed a commit that referenced this issue Sep 25, 2020
@oeciteam @radhikaj
Merge #3589
62732c6 
3589: Deprecate gcc in the Changelog r=radhikaj a=radhikaj

Signed-off-by: Radhika Jandhyala <radhikaj@microsoft.com>

See issue: #3555




Co-authored-by: Radhika Jandhyala <radhikaj@microsoft.com>
bors bot pushed a commit that referenced this issue Sep 25, 2020
@oeciteam @radhikaj
Merge #3589
1b1f74b 
3589: Deprecate gcc in the Changelog r=radhikaj a=radhikaj

Signed-off-by: Radhika Jandhyala <radhikaj@microsoft.com>

See issue: #3555




Co-authored-by: Radhika Jandhyala <radhikaj@microsoft.com>
@mingweishih mingweishih added the SGX Tag indicating associated with Intel SGX label Jan 9, 2021
@mingweishih
Copy link
Collaborator

Note that this issue only affects x86 build. For OP-TEE on the aarch64, we still support aarch64 gcc toolchain.

@mingweishih mingweishih mentioned this issue Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radhikaj radhikaj

Labels
build Issue is related to the build system ci/cd Issue is related to the code integration/deployment pipeline devtools Issue is related to Open Enclave SDK tools and debugging documentation Issue describes the need for updated or additional documentation for the repo or SDK SGX Tag indicating associated with Intel SGX triaged This label classifies an issue/PR as having been triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radhikaj @mingweishih