Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Add postRaw$ method to send raw (already signed) transactions #79

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Add postRaw$ method to send raw (already signed) transactions #79

merged 2 commits into from
Jan 3, 2019

Conversation

axelchalon
Copy link
Contributor

amaury1093
amaury1093 reviewed Dec 31, 2018
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can post$ use postRaw$? If not, can we factorize the same bits of code in another function?

packages/light.js/src/rpc/other/post.ts Outdated

observer.next({ signed: transactionHash });

// We poll `eth_getTransactionReceipt` for 20s, until we get a valid receipt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 times? (I know, I'm the OP of this comment, so my bad)

amaury1093
amaury1093 approved these changes Jan 3, 2019
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaury1093
Copy link
Collaborator

Hey Axel, I'm fine to merge this as-is, but (maybe for the future), what do you think of doing:

  • let post$ make a eth_signtransaction
  • post$ waits for the signer confirmation
  • post$ calls postRaw$

@amaury1093 amaury1093 merged commit 4cbf0f0 into master Jan 3, 2019
@amaury1093 amaury1093 deleted the ac-postraw branch January 3, 2019 16:08
@axelchalon
Copy link
Contributor Author

axelchalon commented Jan 3, 2019 •
edited
Loading

Sounds good! Will make the PR after I'm done with the Signer integration

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
package:light.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelchalon @amaury1093