Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

(FR) user defined parameters #55

Closed
drandreaskrueger opened this issue Sep 4, 2018 · 11 comments
Closed

(FR) user defined parameters #55

drandreaskrueger opened this issue Sep 4, 2018 · 11 comments

Comments

@drandreaskrueger
Copy link

drandreaskrueger commented Sep 4, 2018

At the moment I am manually adding

--geth --jsonrpc-server-threads 100 --tx-queue-size 20000 --cache-size 4096 --tracing off --gas-floor-target 50000000 --pruning fast --tx-queue-mem-limit 0 --no-dapps --no-secretstore-http

to the resulting docker-compose.yml after running ./parity-deploy.sh --config aura --name myaura --nodes 4

A new CLI switch could be useful, like

NODEARGS="--geth --jsonrpc-server-threads 100 --tx-queue-size 20000 --cache-size 4096 --tracing off --gas-floor-target 50000000 --pruning fast --tx-queue-mem-limit 0 --no-dapps --no-secretstore-http"
./parity-deploy.sh --config aura --name myaura --nodes 4 --args $NODEARGS
docker-compose up
@drandreaskrueger
Copy link
Author

workaround for now: I have added those parameters in all 4 files here.

So, feature request not indispensable, but ... nice-to-have.

@drandreaskrueger
Copy link
Author

plus, one more file has to be changed, to almost never hit the gasLimit:

parity-deploy/spec/genesis/aura

to 40 million:

    "genesis": {
        "gasLimit": "0x2625A00"
    },

@ddorgan
Copy link
Collaborator

ddorgan commented Sep 4, 2018

@drandreaskrueger can you just try adding all the extra options at the end of the parity-deploy.sh command ...

e.g.

parity-deploy.sh --config aura --nodes 4 --geth --jsonrpc-server-threads 100 --tx-queue-size 20000 --cache-size 4096 --tracing off --gas-floor-target 50000000 --pruning fast --tx-queue-mem-limit 0 --no-dapps --no-secretstore-http

I should maybe make this more clear in the README.

@drandreaskrueger
Copy link
Author

ah, cool. Thanks.

@drandreaskrueger
Copy link
Author

and the gasLimit? See #60

@ddorgan
Copy link
Collaborator

ddorgan commented Sep 11, 2018

Issue resolved. Won't be updating the gasLimit.

@ddorgan ddorgan closed this as completed Sep 11, 2018
@drandreaskrueger
Copy link
Author

Won't be updating the gasLimit.

I see. What a pity.

Then please consider this route to the same effect: #60

Thanks.

@ddorgan ddorgan reopened this Sep 11, 2018
@ddorgan
Copy link
Collaborator

ddorgan commented Sep 11, 2018

I see. What a pity.

Let me have a look at updating the gasLimit, I'll include with the key generation changes.

@ddorgan
Copy link
Collaborator

ddorgan commented Sep 11, 2018

@drandreaskrueger you can also add --gas-floor-target xxxxx at the end of the command line arguments for this by the way.

@ddorgan
Copy link
Collaborator

ddorgan commented Sep 11, 2018

0937ea2

@ddorgan ddorgan closed this as completed Sep 11, 2018
@drandreaskrueger
Copy link
Author

Let me have a look at updating the gasLimit

hahaha, just seen, you simply hardcoded 40 million now.

That is not what I meant. For for my one situation here, it is actually helpful, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants