Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Merge Notifier and TransactionsPoolNotifier #10581

Closed
IntegralTeam opened this issue Apr 9, 2019 · 1 comment · Fixed by #10591
Closed

Merge Notifier and TransactionsPoolNotifier #10581

IntegralTeam opened this issue Apr 9, 2019 · 1 comment · Fixed by #10591

Comments

@IntegralTeam
Copy link
Contributor

IntegralTeam commented Apr 9, 2019 •
edited
Loading

Merge Notifier
https://github.com/paritytech/parity-ethereum/blob/master/miner/src/pool/listener.rs#L33-L65

and TransactionsPoolNotifier
https://github.com/paritytech/parity-ethereum/blob/master/miner/src/pool/listener.rs#L123-L144

#10558(comments)
@IntegralTeam IntegralTeam mentioned this issue Apr 10, 2019
Merged
2 tasks
@tomusdrw
Copy link
Collaborator

I rather think we should get rid of Notifier completely and just rewrite places where Notifier is used to use TranactionPoolNotifier instead and filter out only Added transactions.

@IntegralTeam IntegralTeam changed the title Re-write Notifier with futures use Merge Notifier and TransactionsPoolNotifier Apr 15, 2019
@IntegralTeam IntegralTeam mentioned this issue Apr 15, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge Notifier and TransactionsPoolNotifier IntegralTeam/parity-ethereum
2 participants
@tomusdrw @IntegralTeam