Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make Externalities::ret consume self #779

Closed
gavofyork opened this issue Mar 19, 2016 · 2 comments
Closed

Make Externalities::ret consume self #779

gavofyork opened this issue Mar 19, 2016 · 2 comments
Labels
F6-refactor 📚 Code needs refactoring. P7-nicetohave 🐕 Issue is worth doing eventually.

Comments

@gavofyork
Copy link
Contributor

Currently ret can be called more than once; it should consume self to avoid this. Will need refactoring so it's called from the owner (Executive, not JIT/Interpreter). This will make much of its code cleaner by avoiding dicking around with mut&s, where moving is actually what should be done.

@gavofyork gavofyork added F6-refactor 📚 Code needs refactoring. P5-sometimesoon 🌲 Issue is worth doing soon. labels Mar 19, 2016
@gavofyork gavofyork added this to the 1.1 Civility milestone Mar 19, 2016
@gavofyork gavofyork added P7-nicetohave 🐕 Issue is worth doing eventually. and removed P5-sometimesoon 🌲 Issue is worth doing soon. labels Mar 21, 2016
@rphmeier
Copy link
Contributor

I am interested in working on this.

@arkpar
Copy link
Collaborator

arkpar commented Mar 30, 2016

@rphmeier Cool, post here or reach us at https://gitter.im/ethcore/parity in case you need any help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F6-refactor 📚 Code needs refactoring. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

3 participants