Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Get the light client to compile for iOS #7955

Closed
tomaka opened this issue Feb 20, 2018 · 9 comments
Closed

Get the light client to compile for iOS #7955

tomaka opened this issue Feb 20, 2018 · 9 comments
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@tomaka
Copy link
Contributor

tomaka commented Feb 20, 2018

So that it can be used as a library by application, or as a background service (if that's possible on iOS).

@tomaka tomaka added P7-nicetohave 🐕 Issue is worth doing eventually. Q5-substantial 📓 Can be fixed by a developer with decent experience. labels Feb 20, 2018
@rphmeier
Copy link
Contributor

cc #4842

@5chdn 5chdn added this to the 1.11 milestone Feb 21, 2018
@5chdn 5chdn added M4-core ⛓ Core client code / Rust. F8-enhancement 🎊 An additional feature request. labels Feb 21, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@tomaka
Copy link
Contributor Author

tomaka commented Mar 1, 2018

I could tackle the technical part of this, but I don't have any iPhone, Mac or Apple device in general.

@5chdn
Copy link
Contributor

5chdn commented Mar 1, 2018

Let's get you some devices then. 💻

@ratake
Copy link

ratake commented Mar 8, 2018

I got parity compiling for and running on iOS – it was fairly straightforward because iOS is very similar to macOS. The changes I had to make were:

@ratake
Copy link

ratake commented Mar 8, 2018

It would still need #4842 to be usable inside of an iOS app or extension (also light syncing needs some love in general).

@rphmeier
Copy link
Contributor

rphmeier commented Mar 9, 2018

@ratake nice work! it's true, we do need a library as well as better light sync. #8075 should address some of the syncing issues but beyond that we need stronger guarantees from the consensus layer.

could you submit a PR?

@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@tomaka tomaka removed the Q5-substantial 📓 Can be fixed by a developer with decent experience. label May 22, 2018
@tomaka
Copy link
Contributor Author

tomaka commented Jul 4, 2018

I've looked a bit into this issue today, as I had exceptionally access to a Mac.

The heapsize situation is quite problematic.
We should be able to replace it with the malloc_size_of crate of servo, but that means we have to propagate the change throughout the dependency tree.
EDIT: malloc_size_of pulls up half of the Servo ecosystem.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 4, 2018

We also need cc-rs to pass a flag to the linker when building a library. Unfortunately, the rust-crypto crate still uses gcc-rs and doesn't seem to be maintained anymore. Hence the build fails.

Either we fork rust-crypto to use cc-rs, or we remove the rust-crypto dependency entirely. I would suggest the latter.

@5chdn 5chdn modified the milestones: 2.1, 2.2 Jul 17, 2018
@5chdn 5chdn added this to the 2.3 milestone Sep 27, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Oct 29, 2018
@5chdn 5chdn modified the milestones: 2.4, 2.5 Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.5, 2.6 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.6, 2.7 Apr 2, 2019
@adria0
Copy link

adria0 commented Jul 27, 2020

Closing issue due to its stale state.

@adria0 adria0 closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

6 participants