Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Decoding headers can fail #8553

Closed
2 tasks done
dvdplm opened this issue May 7, 2018 · 0 comments
Closed
2 tasks done

Decoding headers can fail #8553

dvdplm opened this issue May 7, 2018 · 0 comments
Assignees
@dvdplm
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone
2.0 Ethereum

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented May 7, 2018 •
edited by debris
Loading

In ethcore, encoder.rs does not handle decoding errors. Make Header::decode, Block::decode return Result and fix the resulting problems in consuming code.
@dvdplm dvdplm mentioned this issue May 7, 2018
Merged
@dvdplm dvdplm self-assigned this May 7, 2018
@5chdn 5chdn added this to the 1.12 milestone May 7, 2018
@5chdn 5chdn added M4-core ⛓ Core client code / Rust. F6-refactor 📚 Code needs refactoring. P5-sometimesoon 🌲 Issue is worth doing soon. labels May 7, 2018
dvdplm referenced this issue May 8, 2018
@dvdplm
Merge branch 'fix/rlp-decode-returns-result-issue-8033' into fix/deco…
dc3269a 
…ding-headers-can-fail-#8553

* fix/rlp-decode-returns-result-issue-8033:
  Do not continue reading from the DB when a value could not be read
dvdplm referenced this issue May 8, 2018
@dvdplm
Merge branch 'master' into fix/decoding-headers-can-fail-#8553
9ecd8c9 
* master:
  Rlp decode returns Result (#8527)
  Node table sorting according to last contact data (#8541)
  Keep all enacted blocks notify in order (#8524)
  ethcore, rpc, machine: refactor block reward application and tracing (#8490)
  Consolidate crypto functionality in `ethcore-crypto`. (#8432)
  EIP 145: Bitwise shifting instructions in EVM (#8451)
  Remove expect (#8536)
  Don't panic in import_block if invalid rlp (#8522)
  Pass on storage keys tracing to handle the case when it is not modified (#8491)
  Fetching logs by hash in blockchain database (#8463)
  Transaction Pool improvements (#8470)
  More changes for Android (#8421)
  Enable WebAssembly and Byzantium for Ellaism (#8520)
  SecretStore: merge two types of errors into single one + Error::is_non_fatal (#8357)
  Hardware Wallet trait (#8071)
  Directly return None if tracing is disabled (#8504)
  Show imported messages for light client (#8517)
This was referenced May 8, 2018
Merged
Merged
@debris debris closed this as completed May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dvdplm dvdplm

Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Milestone
2.0 Ethereum
Development

No branches or pull requests
3 participants
@dvdplm @debris @5chdn